Code practice
Pull Request Protocols
Guidelines for manual testing, side quests, and E2E tests.
Manual Testing
- Manual testing is critical before any PR is up for review
- Consider the total "possibility space" and implications/downstream consequences for each PR
- Make sure to test for "unhappy paths" as well as happy paths
Side Quests
- Stick to the scope of the task given to you
- Do not refactor existing code unless it's part of the task
- This can cause visibility issues and make reviewing the PR much harder
- If the area of code you're working on clearly needs tidying up, please raise or propose a refactor ticket to Greg
E2Es
- E2Es are a gift and a curse
- They save our butts
- They can also fail in mysterious and infuriating ways
- Talk to Greg if you find yourself stuck in E2E swamp